Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump github.com/showwin/speedtest-go from 1.7.7 to 1.7.9 #15842

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

r3inbowari
Copy link
Contributor

@r3inbowari r3inbowari commented Sep 4, 2024

Summary

showwin/speedtest-go@332a0d7 fix: data races
showwin/speedtest-go@96bd45a fix: keepalive state broken

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #11449

Signed-off-by: r3inbowari <r3inbowari@gmail.com>
@telegraf-tiger telegraf-tiger bot added the chore label Sep 4, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Sep 4, 2024

@melroy89
Copy link

melroy89 commented Sep 4, 2024

Thank you!

This new speedtest-go release fixes a bug in the upload part, so it now closes the connection for port re-use. Which means I now get the correct speedtest results (especially the upload part, is now showing an increase from ~900Mb/s to ~2.3 Gbit/s).

    speedtest-go v1.7.9 (git-dd78c65) @showwin

✓ ISP: secret
✓ Found 50 Public Servers

✓ Test Server: [13157] 3.43km Amsterdam (Netherlands) by AVUR AS
✓ Latency: 6.654303ms Jitter: 594.226µs Min: 5.590104ms Max: 7.277726ms
✓ Packet Loss Analyzer: Running in background (<= 30 Secs)
✓ Download: 2247.65 Mbps (Used: 2858.34MB) (Latency: 9ms Jitter: 1ms Min: 6ms Max: 12ms)
✓ Upload: 2263.52 Mbps (Used: 2859.66MB) (Latency: 16ms Jitter: 10ms Min: 5ms Max: 43ms)
✓ Packet Loss: 0.00% (Sent: 268/Dup: 0/Max: 267)

@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 4, 2024
@srebhan srebhan added the dependencies Pull requests that update a dependency file label Sep 4, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @r3inbowari for your active maintenance!

@srebhan srebhan merged commit fc2d714 into influxdata:master Sep 4, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Sep 4, 2024
@r3inbowari r3inbowari deleted the deps/speed179 branch September 5, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internet_speed giving much lower download results (<200 Mbps vs 900 Mbps)
4 participants