Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.snmp): Add displayhint conversion #15935

Merged
merged 8 commits into from
Oct 2, 2024
Merged

feat(inputs.snmp): Add displayhint conversion #15935

merged 8 commits into from
Oct 2, 2024

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 24, 2024 •
edited
Loading

Summary

Add option to format the returned value from SNMP according to the textual convention from the MIB, for example the DateAndTime. The return type for this field will then be string.

Checklist

  • No AI generated code was used in this PR
  • Update processors.snmp_lookup docs
  • Deprecate redundant conversion options

@telegraf-tiger telegraf-tiger bot added area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 24, 2024
@Hipska Hipska force-pushed the feat/snmp/display_hint branch from 8e0bf8f to 13e0c22 Compare September 25, 2024 12:15
@Hipska Hipska marked this pull request as ready for review September 25, 2024 12:15
srebhan
srebhan reviewed Oct 1, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Hipska! Just one comment as we don't want implicit return-value declarations if avoidable.

internal/snmp/field.go Outdated Show resolved Hide resolved
internal/snmp/field.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Oct 1, 2024
srebhan
srebhan reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more...

internal/snmp/field.go Outdated Show resolved Hide resolved
srebhan
srebhan approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska!

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 2, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@Hipska Hipska mentioned this pull request Oct 2, 2024
Closed
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 2, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 2, 2024
@DStrand1 DStrand1 merged commit ddd6023 into influxdata:master Oct 2, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 2, 2024
@Hipska Hipska deleted the feat/snmp/display_hint branch October 2, 2024 15:34
@Hipska Hipska mentioned this pull request Oct 8, 2024
Closed
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@Hipska @asaharn
feat(inputs.snmp): Add displayhint conversion (influxdata#15935)
44f90c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hipska @srebhan @DStrand1