fix(logging): Add Close() func for redirectLogger #16219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Telegraf provides the function RedirectLogging(w io.Writer) which allows the user to optionally redirect the log to a customized sink by wrapping the instance.impl as a redirectLogger. In this case, when the user tries to close this sink by calling logger.CloseLogging() func (which internally calls handler.close()), the sink closing will not take effect because redirectLogger is not an io.Closer, while the handler only do the close after checking it is an io.Closer. This PR fixes this issue by implementing the Close() function for redirectLogger to make it as an io.Closer().
This issue only happens when redirectLogger is used. In comparion, other sink interface implementations (like textLogger and structuredLogger don't have this issue as both of them have already implemented the Close() function.
Checklist
Related issues
resolves #16218