Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bagelswitch master #1715

Merged
merged 2 commits into from
Sep 6, 2016
Merged

Bagelswitch master #1715

merged 2 commits into from
Sep 6, 2016

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Sep 6, 2016 •
edited
Loading

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • README.md updated (if adding a new plugin)

@sparrc sparrc mentioned this pull request Sep 6, 2016
Closed
3 tasks
ncohensm and others added 2 commits September 6, 2016 17:21
@sparrc
initial http_listener implementation
67c288a 
fix incredibly stupid bugs

populate README

support query endpoint and change default listen port

set response headers for query endpoint

add unit tests

revert erroneous Godeps change

add plugin ref to top-level README

remove debug output and add empty post body test

fix linter errors

move stoppableListener into repo

use constants for http status codes

add CHANGELOG entry

address code review comments re. style/structure

address further code review comments

add note to README re. database creation calls per PR comments
@sparrc
Add a 404 and high-traffic test to http listener
301c79e 
also remove locking around adding metrics. Instead, keep a waitgroup on
the ServeHTTP function and wait for that to finish before returning from
the Stop() function

closes #1407
@sparrc sparrc merged commit 301c79e into master Sep 6, 2016
@sparrc sparrc deleted the bagelswitch-master branch September 7, 2016 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sparrc