Solr plugin #1734
Closed
Solr plugin #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| servers = ["http://localhost:8983"] | ||
|
|
||
| ## specify a list of one or more Solr cores | ||
| cores = ["main"] |
There was a problem hiding this comment.
Thoughts on having the plugin capture all cores by default without having to manually specify them?
|
Just a thought, but would it be possible to come up with a generic way of just passing the metrics straight through, instead of having to hard code a struct with specific json tags? It would make the plugin more future proof. |
|
@sparrc any chance for a next release? |
|
@ljagiello could you provide an example output of the metrics gathered in the README? |
|
it could be merged for 1.2 |
|
@sparrc done. |
added 6 commits
November 9, 2016 07:39
Solr plugin collecting metrics from Apache Solr server. Issue (#278)
|
mess up with this one during rebase - new PR here: #2019 |
|
Just FYI, you don't have to open a new PR. As long as the branch name is the same, you can do a force push and PR will get updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Solr plugin collecting metrics from Apache Solr server.
Issue (#278)