Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snmp: fix initialization of table fields in manual tables #1836

Merged
merged 1 commit into from
Oct 12, 2016
Merged

snmp: fix initialization of table fields in manual tables #1836

merged 1 commit into from
Oct 12, 2016

Conversation

phemmer
Copy link
Contributor

@phemmer phemmer commented Oct 2, 2016 •
edited
Loading

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)

Fixes a bug where if you manually build out an SNMP table, and use textual OIDs, they don't get initialized, resulting in errors like:

2016/10/02 01:58:45 ERROR in input [snmp]: agent 10.1.199.11: performing bulk walk: marshal: Unable to parse OID: strconv.ParseInt: parsing "IF-MIB::ifDescr": invalid syntax

@dgnorton dgnorton added this to the 1.1.0 milestone Oct 6, 2016
sparrc
sparrc approved these changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@sparrc sparrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparrc
Copy link
Contributor

sparrc commented Oct 11, 2016

can you rebase?

@phemmer
Copy link
Contributor Author

phemmer commented Oct 11, 2016

rebased

@sparrc sparrc merged commit 80df3f7 into influxdata:master Oct 12, 2016
@phemmer phemmer deleted the fix-snmp-manual-table-fields branch October 12, 2016 12:12
@sparrc sparrc mentioned this pull request Nov 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparrc sparrc sparrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phemmer @sparrc @dgnorton