Switch to poll mode to detect file changes in logparser #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tail doesn't work in macos(default use inotify, but it doesn't work in macos). set poll to true works.
danielnelson
suggested changes
May 27, 2017
| @@ -82,7 +82,8 @@ func (l *LogParserPlugin) Gather(acc telegraf.Accumulator) error { | |||
| defer l.Unlock() | |||
|
|
|||
| // always start from the beginning of files that appear while we're running | |||
| return l.tailNewfiles(true) | |||
| // why need to set true? It's ok to set l.FromBeginning. | |||
| return l.tailNewfiles(l.FromBeginning) | |||
There was a problem hiding this comment.
When this parameter is false, we seek to the end of the file before reading. To ensure the entire file is read we need to leave this as true.
| @@ -159,6 +160,7 @@ func (l *LogParserPlugin) tailNewfiles(fromBeginning bool) error { | |||
| Follow: true, | |||
| Location: &seek, | |||
| MustExist: true, | |||
| Poll: true, //inotify(default) not work in macos(darwin). poll test ok. | |||
There was a problem hiding this comment.
What we could do here is allow this to be configurable. We can add an option to the plugin called watch_method with available options "poll" and "inotify". If unset, we could automatically pick an implementation.
danielnelson
changed the title
2 tasks
|
Closing in favor of #3213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tail doesn't work in macos(default use inotify, but it doesn't work in macos). set poll to true works.
Required for all PRs: