Add RabbitMQ cluster and running nodes count and running node status #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Partially covers #3252 to add a |
askainet
force-pushed
the
rabbitmq_node_running
branch
from
6b5d34c
to
d9b0cd2
Compare
…ds to the "rabbitmq_overview" measurement; add "running" field to the "rabbitmq_node" measurement
askainet
force-pushed
the
rabbitmq_node_running
branch
from
d9b0cd2
to
de790f5
Compare
phemmer
reviewed
Jan 19, 2018
plugins/inputs/rabbitmq/README.md
Outdated
| @@ -61,6 +61,8 @@ For additional details reference the [RabbitMQ Management HTTP Stats](https://cd | |||
| - messages_ready (int, messages) | |||
| - messages_unacked (int, messages) | |||
| - queues (int, queues) | |||
| - cluster_nodes (int, member nodes) | |||
| - running_nodes (int, nodes up) | |||
There was a problem hiding this comment.
All the other metrics are noun_adjective, these new ones are adjective_noun
There was a problem hiding this comment.
Good point, then I propose
cluster_nodes => nodes_member
running_nodes => nodes_running
There was a problem hiding this comment.
How about clustering_listeners and amqp_listeners?
There was a problem hiding this comment.
That would be 100% accurate. Agreed, let the user decide the practical meaning of those metrics then.
danielnelson
added
the
feat
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runningfield to therabbitmq_nodemeasurement directly mapped to therunningflag from the output of/api/nodesclustering_listenersto therabbitmq_overviewmeasurement as the total count of listeners of protocolclusteringfrom the output of/api/overviewamqp_listenersto therabbitmq_overviewmeasurement as the total count of listeners of protocolamqpfrom the output of/api/overviewRequired for all PRs: