Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add consumption, add device id as tag, modify documentation and tests #4343

Merged

Conversation

dynek
Copy link
Contributor

@dynek dynek commented Jun 26, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This PR implement features requested here:

@dynek dynek force-pushed the feature/fibaro_plugin_add_consumption branch from b2ad99a to 6dd56e3 Compare June 26, 2018 09:23
@danielnelson danielnelson added this to the 1.8.0 milestone Jul 2, 2018
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 2, 2018
@danielnelson danielnelson merged commit b2586a7 into influxdata:master Jul 2, 2018
@mathiasahlen
Copy link

Tested the nightly build and these new features and they work perfectly. Thank you very much @dynek for implementing this.

@dynek
Copy link
Contributor Author

dynek commented Jul 6, 2018

My pleasure

rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants