Don't pass empty measurement name to AddFields #4849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should configure the parser to produce metrics with names, let's set the measurement name to the defealt in Start, make sure that ParseLine returns the metric with a name and we can call m.Name() to pass it to acc.AddFields. |
danielnelson
approved these changes
Oct 17, 2018
glinton
added a commit
that referenced
this pull request
Oct 17, 2018
marcosnils
added a commit
to marcosnils/telegraf
that referenced
this pull request
Oct 23, 2018
marcosnils
added a commit
to marcosnils/telegraf
that referenced
this pull request
Oct 23, 2018
Fixes influxdata#4849 Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4816