Support Azure Sovereign Environments with EndpointOverride argument #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overiegn Azure Cloud metrics gathering. E.g. Azure US Government endpoint needs an override.
in the azure_monitor output.
danielnelson
added
the
feat
danielnelson
added
the
area/azure
|
Perfect, thank you! |
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure sovereign cloud environments do not conform to the
<region>.monitoring.azure.comendpoint address. This proposed change looks to allow for an override of the endpoint URL so that metrics can be pushed to the appropriate URL and Azure Monitor.Attempts to address #5452 and this is my first PR to this project. Before I continue further, I'd like to get some insight/feedback on this approach and if it seems reasonable, will continue by building out the necessary unit tests (e.g. endpoint_override = "testymctesturl.testing")?
Comments and insights appreciated (also, I'm not a go programmer by any means, but wanted to contribute this)
Required for all PRs: