-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floats in statsd percentiles (rebased with master) #5572
Floats in statsd percentiles (rebased with master) #5572
Conversation
…always have to be indicated as floats
…g both integers and floats
The circleci tests seem to have failed due to errors in quay.io. Can we re-trigger them? |
By the way: what is the process for having this merged into the next minor release for, say, 1.10 and 1.9? I'd like to see this in at least those versions, as those are the current and the likely next versions I'm using. Thanks! |
We generally only backport bugfixes, and only to the latest release (1.10 as of now). Features are added to the next minor release (1.11 as of now). |
Hi, Thank you. |
Can you add a unit test that exercises a non-even floating point value, such as the 99.5th percentile? |
@danielnelson: Added, along with other marginal cases. |
Required for all PRs:
This addresses #5527. Additionally to the previous PR (#5528), here I'm trying not to do any breaking change:
[50, 90, 100]
);[50.0, 90.0, 99.0, 99.9, 100.0]
).[50, 90, 99, 99.9, 100]
), which I think is reasonable.This is now targetted at the current
master
branch.The already-present Unit Tests were only slightly changed to accept the correct type. No new tests were added.