Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user agent in all Stackdriver requests #5901

Merged
merged 4 commits into from
May 24, 2019
Merged

Set user agent in all Stackdriver requests #5901

merged 4 commits into from
May 24, 2019

Conversation

jkohen
Copy link
Contributor

@jkohen jkohen commented May 23, 2019

Can you advice on what tests and doc updates you'd like for this change?

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson
Copy link
Contributor

Thanks for the pr, I think manual testing will be fine on this one.

@danielnelson danielnelson added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver labels May 24, 2019
@jkohen
Copy link
Contributor Author

jkohen commented May 24, 2019

This is ready for your review.

@danielnelson danielnelson added this to the 1.11.0 milestone May 24, 2019
@danielnelson danielnelson merged commit adb7a52 into influxdata:master May 24, 2019
hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request Jun 13, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants