-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kubernetes): remove usage of deprecated API endpoints, v1beta #6543
Conversation
011bccd
to
afa81c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Based on your comments on the issue then this would break compatibility with k8s <1.9, is the 1.8 version something that was previously supported by this plugin? If so, we probably need to add an option to opt into this change. Either way we should document the first version this plugin supports. Were these new APIs also added in 1.9? |
1.8 has been EOL for a year. Of course, that doesn't mean people aren't still on it. These changes will break for <= 1.8 We could check the API version and act accordingly, but I'd be worried about how long that code would be there and how many code paths we'll have after another year of Kubernetes releases (minor release every 16 weeks) What do you think is best? |
If it used to work, but now it doesn't, we ought to keep it around. Unless we have a strong belief that no one is using it with 1.8 or older. When was 1.9 released? Either way I'd really like to set the bar with a minimum supported version in the documentation. |
1.9 was released December 2017 |
As we discussed offline, let's document in the README (last paragraph of the first section) the minimum version that we are going to support going forward with this plugin. Set it to the oldest version supported by AWS+GCP+Azure, we can use the new API from this PR without keeping around the legacy support. |
TL;DR No major cloud provider allows for a version that wouldn't include support for the Q: Which Kubernetes versions does Amazon EKS support? A: Amazon EKS supports Kubernetes version 1.11, 1.12, 1.13, and 1.14 and will continue to add support for additional Kubernetes versions in the future.
While worker versions can use from
Azure supports 4 minor versions, which means |
afa81c1
to
c67fa2e
Compare
@danielnelson Updated. Please let me know if this is what you had in mind, or if you'd like further changes. Thanks for your continued assistance 👍 |
So let's say 1.11 is the first version we will support. Can you verify your changes are working with 1.11 then and add a paragraph to the readme:
|
Confirmed working. Steps to reproduce: Get a Kubernetes 1.11 cluster
Save Dockerfile to Telegraf local clone:
Build custom Telegraf from branch:
Deploy Telegrafs
Check it's working:
Browsing to http://localhost:9999 and you should be able to explore metrics for |
c67fa2e
to
b94672f
Compare
Added to both |
b94672f
to
04fd125
Compare
Required for all PRs:
Closes #6542