Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input: Diskio] Invalid diskinfo cache if the device Mtim has changed #6835

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

johnsudaar
Copy link
Contributor

@johnsudaar johnsudaar commented Dec 30, 2019

closes #6345

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@johnsudaar
Copy link
Contributor Author

Fix #6345

@johnsudaar johnsudaar force-pushed the fix/6345/disk_info_cache branch from 6f631ff to e93c59b Compare December 30, 2019 14:01
@johnsudaar
Copy link
Contributor Author

I'm unsure on how to write the tests since the specs uses a dummy device on /dev/null however i can't modify the mtim of this device.

@danielnelson danielnelson added this to the 1.13.1 milestone Dec 30, 2019
@danielnelson danielnelson added the fix pr to fix corresponding bug label Dec 30, 2019
@danielnelson
Copy link
Contributor

I think it is okay to skip unit tests for now, we would need to make much larger changes to test this particular aspect.

@danielnelson danielnelson merged commit 01e31e9 into influxdata:master Dec 30, 2019
danielnelson pushed a commit that referenced this pull request Dec 30, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Input: DiskIO] Deleted devices are not deleted from the diskInfoCache
3 participants