Sumo Logic output plugin: fix unparsable config.Size from sample config #8243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to get this before |
reimda
suggested changes
Oct 21, 2020
reimda
approved these changes
Oct 21, 2020
|
Thanks @pmalek-sumo! |
|
No problem, thanks for merging this |
reimda
pushed a commit
that referenced
this pull request
Oct 21, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deciding to use
config.Sizein e9dcade I've noticed that it usesParseStrictBytesfrom https://github.com/alecthomas/units/blob/b9c82cb/bytes.go#L77-L85 which doesn't understand underscores in numbers.This PR addresses that by changing what's in the sample config not to confuse users.
Required for all PRs: