Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sarama library to 1.27.1 #8289

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Update sarama library to 1.27.1 #8289

merged 3 commits into from
Oct 20, 2020

Conversation

reimda
Copy link
Contributor

@reimda reimda commented Oct 19, 2020

Sarama 1.24.1 has known regressions and the project recommends it should not be used. https://github.com/Shopify/sarama/releases/tag/v1.24.1

@reimda
Copy link
Contributor Author

reimda commented Oct 19, 2020

Sarama 1.27.1 requires go 1.15 but telegraf CI runs on 1.15 and 1.14. We might need to use an older sarama version that builds on 1.14 but also fixes the issues in 1.24.1.

@sjwang90
Copy link
Contributor

#7263

@ssoroka ssoroka merged commit 5a5f6fb into master Oct 20, 2020
@ssoroka ssoroka deleted the update-sarama branch October 20, 2020 15:42
ssoroka pushed a commit that referenced this pull request Oct 20, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants