Fix reconnection issues mqtt #8821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
sspaink
approved these changes
Feb 9, 2021
ssoroka
approved these changes
Feb 11, 2021
| @@ -184,6 +184,7 @@ func (m *MQTTConsumer) Init() error { | |||
| } | |||
|
|
|||
| m.opts = opts | |||
| m.messages = make(map[telegraf.TrackingID]bool) | |||
There was a problem hiding this comment.
not a big deal, but I prefer not using make when there's no allocation size
Suggested change
| m.messages = make(map[telegraf.TrackingID]bool) | |
| m.messages = map[telegraf.TrackingID]bool{} |
| @@ -84,6 +85,10 @@ func (t *FakeToken) SessionPresent() bool { | |||
| return t.sessionPresent | |||
| } | |||
|
|
|||
| func (t *FakeToken) Done() <-chan struct{} { | |||
There was a problem hiding this comment.
doesn't appear to be used anywhere. is this for an interface?
There was a problem hiding this comment.
When I updated the package the tests wouldn't run until I added this
ssoroka
pushed a commit
that referenced
this pull request
Feb 17, 2021
(cherry picked from commit f3a208e)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8722, #7648
When there is a network interruption or anything to cause a connection failure the input would not recover without restarting Telegraf.
Eg the following:
E.g connection lost EOF or connection lost pingresp not receivedWould cause it to repeat loop on the messages below and not resume gathering metrics without a restart.
Upgraded to eclipse/paho.mqtt.golang v1.3.0 which includes fixes for reconnection errors.
Moved the make of m.messages into the Init function so it is only called once rather than on every reconnect, so in the event of a reconnection error once it reconnects it recovers.