feat(http_listener_v2): allows multiple paths and add path_tag #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-paths
branch
from
757e792 to
ad3227a
Compare
srebhan
reviewed
Jul 22, 2021
There was a problem hiding this comment.
Hey @sumo-drosiek thanks for this nice contribution! I added some minor comments in the code. Please keep the change backward compatible as users rely on the fact that a new telegraf still works with old config files.
srebhan
added
the
plugin/input
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-paths
branch
from
547f098 to
84e7904
Compare
srebhan
reviewed
Jul 23, 2021
sumo-drosiek
force-pushed
the
drosiek-paths
branch
from
e70e6aa to
f16bf70
Compare
sumo-drosiek
changed the title
…to store path Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-paths
branch
from
f16bf70 to
8b4000d
Compare
srebhan
reviewed
Jul 23, 2021
There was a problem hiding this comment.
Thanks for the quick cycles. The only thing left is to only add the Path if it is not empty and not yet in Paths (you create a duplication by default in your init()). Furthermore, there is a spurious config.yaml file that should not go into the repo I thinks.
added 3 commits
July 23, 2021 15:20
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-paths
branch
from
fd96afb to
d6b440d
Compare
…2 changes Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-paths
branch
from
af02d8e to
9e68e53
Compare
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
|
@srebhan I believe all issues have been resolved |
sumo-drosiek
pushed a commit
to SumoLogic/telegraf
that referenced
this pull request
Jul 26, 2021
rel: influxdata#9529 Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
pushed a commit
to SumoLogic/telegraf
that referenced
this pull request
Jul 26, 2021
rel: influxdata#9529 Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
srebhan
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Looks good to me. Thanks for this nice contribution @sumo-drosiek!
srebhan
added
the
ready for final review
sspaink
approved these changes
Jul 27, 2021
sumo-drosiek
added a commit
to SumoLogic/telegraf
that referenced
this pull request
Jul 29, 2021
phemmer
added a commit
to phemmer/telegraf
that referenced
this pull request
Aug 13, 2021
* origin/master: (183 commits) fix: CrateDB replace dots in tag keys with underscores (influxdata#9566) feat: Pull metrics from multiple AWS CloudWatch namespaces (influxdata#9386) fix: improve Clickhouse corner cases for empty recordset in aggregation queries, fix dictionaries behavior (influxdata#9401) fix(opcua): clean client on disconnect so that connect works cleanly (influxdata#9583) fix: Refactor ec2 init for config-api (influxdata#9576) fix: sort logs by timestamp before writing to Loki (influxdata#9571) fix: muting tests for udp_listener (influxdata#9578) fix: Do not return on disconnect to avoid breaking reconnect (influxdata#9524) fix: Fixing k8s nodes and pods parsing error (influxdata#9581) feat: OpenTelemetry output plugin (influxdata#9228) feat: Support AWS Web Identity Provider (influxdata#9411) fix: upgraded sensu/go to v2.9.0 (influxdata#9577) fix: Normalize unix socket path (influxdata#9554) docs: fix aws ec2 readme inconsistency (influxdata#9567) feat: Modbus Rtu over tcp enhancement (influxdata#9570) docs: information on new conventional commit format (influxdata#9573) docs: Add logo (influxdata#9574) docs: Adding links to net_irtt and dht_sensor external plugins (influxdata#9569) Upgrade hashicorp/consul/api to 1.9.1 (influxdata#9565) Update vmware/govmomi to v0.26.0 (influxdata#9552) Do not skip good quality nodes after a bad quality node is encountered (influxdata#9550) fix test so it hits a fake service (influxdata#9564) Update changelog Fix procstat plugin README to match sample config (influxdata#9553) Fix metrics reported as written but not actually written (influxdata#9526) Prevent segfault in persistent volume claims (influxdata#9549) Update procstat to support cgroup globs & include systemd unit children (Copy of influxdata#7890) (influxdata#9488) Fix attempt to connect to an empty list of servers. (influxdata#9503) Fix handling bool in sql input plugin (influxdata#9540) Suricata alerts (influxdata#9322) Linter fixes for plugins/inputs/[fg]* (influxdata#9387) For Prometheus Input add ability to query Consul Service catalog (influxdata#5464) Support Landing page on Prometheus landing page (influxdata#8641) [Docs] Clarify tagging behavior (influxdata#9461) Change the timeout from all queries to per query (influxdata#9471) Attach the pod labels to the `kubernetes_pod_volume` & `kubernetes_pod_network` metrics. (influxdata#9438) feat(http_listener_v2): allows multiple paths and add path_tag (influxdata#9529) Bug Fix Snmp empty metric name (influxdata#9519) Worktable workfile stats (influxdata#8587) Update Go to v1.16.6 (influxdata#9542) ...
pmalek-sumo
pushed a commit
to SumoLogic/telegraf
that referenced
this pull request
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
resolves #
Convert
pathconfiguration topathsto allow getting metrics on multiple endpoints. In addition addingpath_tagconfiguration option, so path can be included in defined tag name