Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough gzip param to http crate #120

Open
NiwakaDev opened this issue Mar 29, 2023 · 2 comments
Open

Passthrough gzip param to http crate #120

NiwakaDev opened this issue Mar 29, 2023 · 2 comments

Comments

@NiwakaDev
Copy link

According to Use gzip compression, influxdb supports gzip compression. I think that influxdb-rust should support this.

//...
let enable_gzip = true;
let client = Client::new("http://localhost:8086", "test", enable_gzip);
//...

I guess that we can use flate2-rs to implement this feature.

If you agree with this feature, I'd like to implement this.

@msrd0
Copy link
Collaborator

msrd0 commented Mar 29, 2023

We give you the choice of using reqwest or surf as the HTTP client. I know that reqwest supports gzip encoding, and I'd assume surf also supports it. Either way, there's absolutely no need to implement gzip in this crate. The most we could do is pass through the gzip feature to the respective HTTP client, as at least reqwest requires a feature for gzip to be enabled.

@Empty2k12 Empty2k12 changed the title Support gzip Passthrough gzip param to http crate Apr 4, 2024
@Empty2k12
Copy link
Collaborator

I have adapted the issue title. Like @msrd0 said, it makes the most sense to include a toggle in the crate that enables gzip in the underlying http crate used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants