Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InfluxDbWriteable procedural derive macro #23

Merged
merged 57 commits into from
Mar 17, 2020
Merged

Add InfluxDbWriteable procedural derive macro #23

merged 57 commits into from
Mar 17, 2020

Conversation

msrd0
Copy link
Collaborator

@msrd0 msrd0 commented Oct 9, 2019

Fixes #19

@Empty2k12 Empty2k12 removed this from the Release 0.0.5 milestone Oct 11, 2019
@msrd0
Copy link
Collaborator Author

msrd0 commented Oct 12, 2019

The InfluxDbWriteable macro should now be working. I don't know if a InfluxDbReadable macro makes sense and what the use case would be? Maybe someone could give an example how they'd like to use it

@msrd0 msrd0 changed the title [WIP] Add proc macro derive Add proc macro derive Oct 12, 2019
@Empty2k12
Copy link
Collaborator

CI is failing with

README.md out of date. Run "cargo readme > README.md" and commit again.

@msrd0
Copy link
Collaborator Author

msrd0 commented Oct 13, 2019

@Empty2k12 I've fixed the readme. Kcov is still failing with an error message I cannot understand. Do you have an idea how to fix kcov?

@Empty2k12
Copy link
Collaborator

I would guess this is due to you changing the folder structure, resulting in a different folder structure inside the target folder which the kcov command relies on.

@Empty2k12 Empty2k12 mentioned this pull request Oct 29, 2019
5 tasks
@Empty2k12 Empty2k12 mentioned this pull request Dec 18, 2019
Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the new release process work, again?

I release influxdb_derive first, then update influxdb to it's version and release influxdb?

influxdb/Cargo.toml Outdated Show resolved Hide resolved
influxdb/src/query/mod.rs Outdated Show resolved Hide resolved
@msrd0
Copy link
Collaborator Author

msrd0 commented Mar 16, 2020

From my PoV, this PR is ready to be merged. Releasing will go just like you said ... release the derive crate first, wait a minute to give crates.io time to process the new/updated crate, and then release the main crate which has the derive crate as its dependency. However, note that there is no need to update the derive crate if no changes were made, just don't update the version either. It might be a good idea to keep major/minor versions in sync, at least that's what bigger libraries like diesel seem to be doing.

@Empty2k12
Copy link
Collaborator

Before releasing I will probably fix #54 to improve behavior on embedded platforms.

@Empty2k12 Empty2k12 added Status: Merge when CI passes This PR has been reviewed and accepted for merge and removed Status: Review in Progress labels Mar 17, 2020
Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Empty2k12 Empty2k12 merged commit cb7f08c into influxdb-rs:master Mar 17, 2020
@Empty2k12 Empty2k12 deleted the add-proc-macro-derive branch March 17, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement InfluxDbReadable and InfluxDbWriteable procedural macros
2 participants