-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InfluxDbWriteable procedural derive macro #23
Conversation
…rive Conflicts: Cargo.toml influxdb/src/query/mod.rs
The |
CI is failing with
|
@Empty2k12 I've fixed the readme. Kcov is still failing with an error message I cannot understand. Do you have an idea how to fix kcov? |
I would guess this is due to you changing the folder structure, resulting in a different folder structure inside the target folder which the kcov command relies on. |
…t into add-proc-macro-derive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does the new release process work, again?
I release influxdb_derive
first, then update influxdb
to it's version and release influxdb
?
From my PoV, this PR is ready to be merged. Releasing will go just like you said ... release the derive crate first, wait a minute to give crates.io time to process the new/updated crate, and then release the main crate which has the derive crate as its dependency. However, note that there is no need to update the derive crate if no changes were made, just don't update the version either. It might be a good idea to keep major/minor versions in sync, at least that's what bigger libraries like diesel seem to be doing. |
Before releasing I will probably fix #54 to improve behavior on embedded platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes #19