-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes surf's with_http_client #94
Conversation
Style checks fail on existing code. |
@Empty2k12 thoughts? |
Thanks for your PR! Please merge/rebase main. The compilation failure should go away. Also, #92 has been merged. |
40122ef
to
0bba55e
Compare
Exposed under the "surf" feature. Do you prefer a separate function |
I think I prefer the former. Is there a reason why we don't make a client-agnostic |
Fair point! Updated to match. |
@msrd0 can this be merged? |
@Empty2k12 I was hoping for the CI to run first. No idea why it doesnt, I contacted GitHub Support on Monday asking why they've disabled actions on this repo. |
Description
Exposed Surf's with_http_client to allow users to more granularity in their HTTP clients. One use case is creating a isahc HttpClient with HTTP basic auth
Maintenance considerations
If the project moves away from surf this function will need to be under a surf feature. This function does make moving away from surf a semver major change, looking at #92 it appears a sermver breaking change when moving away from surf is planned.
Checklist
cargo fmt --all
cargo clippy --all-targets --all-features -- -D warnings
dyn
are deprecated.cargo readme -r influxdb -t ../README.tpl > README.md