add script and instruction for protoc plugins debug #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates for readme
Fix readme layout
Evgeniy-L
approved these changes
Nov 9, 2018
tools/debugging/README.md
Outdated
| # Debugging protoc plugins | ||
|
|
||
| Sometimes we need debug our protoc plugins with standart IDE debug tool. | ||
| We have two ways how we can do it. First we can mock input content and start debug session, second use delve remote debug server. |
There was a problem hiding this comment.
I would suggest to make delve a link or put it in quotes
|
@dkukharau We want review from you |
dkukharau
reviewed
Nov 9, 2018
| @@ -0,0 +1,13 @@ | |||
| FROM golang:1.10.0 AS builder | |||
There was a problem hiding this comment.
Why have this file here if we've already put it in README?
There was a problem hiding this comment.
Because we use this file in docker build command, you must change it and use as a default behavior
dkukharau
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I provide some kind of tutorial and utill scripts for protoc plugins debugging