Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/search-by #331

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Feature/search-by #331

merged 7 commits into from
Aug 23, 2022

Conversation

abalaven
Copy link
Contributor

@abalaven abalaven commented Jul 6, 2022

No description provided.

Copy link
Contributor

@Calebjh Calebjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay, and doesn't look like it has any breaking changes to be worried about. It should have added documentation in the README for the new collection operator and what it does though.

@@ -62,6 +67,40 @@ func ApplyCollectionOperatorsEx(ctx context.Context, db *gorm.DB, obj interface{
return db, nil
}

func ApplyCollectionOperatorsWithSearchingEx(ctx context.Context, db *gorm.DB, obj interface{}, c CollectionOperatorsConverter, f *query.Filtering, s *query.Sorting, p *query.Pagination, fs *query.FieldSelection, sc *query.Searching, fieldsForFTS []string) (*gorm.DB, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is a new operator with a separate function, it won't be handled in the normal protoc-gen-gorm generated handlers without changes there.

query/README.md Outdated Show resolved Hide resolved
query/README.md Outdated Show resolved Hide resolved
Co-authored-by: Caleb Horst <chorst@infoblox.com>
@Calebjh Calebjh merged commit 2a142f3 into master Aug 23, 2022
@abalaven abalaven deleted the feature/search-by branch August 23, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants