-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/search-by #331
Feature/search-by #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems okay, and doesn't look like it has any breaking changes to be worried about. It should have added documentation in the README for the new collection operator and what it does though.
@@ -62,6 +67,40 @@ func ApplyCollectionOperatorsEx(ctx context.Context, db *gorm.DB, obj interface{ | |||
return db, nil | |||
} | |||
|
|||
func ApplyCollectionOperatorsWithSearchingEx(ctx context.Context, db *gorm.DB, obj interface{}, c CollectionOperatorsConverter, f *query.Filtering, s *query.Sorting, p *query.Pagination, fs *query.FieldSelection, sc *query.Searching, fieldsForFTS []string) (*gorm.DB, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is a new operator with a separate function, it won't be handled in the normal protoc-gen-gorm generated handlers without changes there.
c0e0eb8
to
3cc3e3e
Compare
Co-authored-by: Caleb Horst <chorst@infoblox.com>
No description provided.