Commits on Dec 21, 2023

1. Resolve panic reflect.Value.Interface on zero value (infobloxopen#396) …

   PROBLEM
   =======
   
   In HTTP API services, a user may specify a `_filter=` specifying a
   field name and an empty string (`field == ""`).
   
   The `ToORM()` codec translates the empty string to a `nil` pointer.
   
   `ProcessStringCondition()` then attempts to take a
   `reflect.Value.Interface` on this nil pointer, causing a panic.
   
   SOLUTION
   ========
   
   Detect the nil pointer value, and return a nil value. The gorm codec
   translates this to a `NULL` value in SQL syntax. This resolves the
   panic, but results in an SQL query that matches no rows
   (`field == NULL`).
   
   DISCUSSION
   ==========
   
   It's arguable what the user intent is here, considering that there is
   existing Atlas filter syntax for `field == null` (resulting in the
   correct identity SQL expression `field IS NULL`). The explicit empty
   string value cannot exist in our interpretation because the codec
   translates it to NULL reliably; a user that POSTs an object with a
   string field set `""` will result in a table row set to NULL.
   
   But we might want to consider that `field == ""` should be an alias for
   the NULL identity expression; the user intent is probably to find rows
   where the field is `""` in their experience of the object.
   
   From one point of view, it is correct that there are never any rows in
   our table with fields of `""` value. From another point of view, there
   are rows in our table with fields not equal to `""` value and that query
   should have results (the `field != ""` syntax seems like it should work).

   

   davidhankins committed Dec 21, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 4b13996
   • Browse repository at this point

   Copy the full SHA

   4b13996 View commit details

   Browse the repository at this point in the history