DDINGI-1306: Revised Data Paging/Totals #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmayb
reviewed
Nov 14, 2024
query/collection_operators.proto
Outdated
Comment on lines
205
to
207
| //The bool value enables/disables the record count. | ||
| //The default setting disables the record count. | ||
| bool is_total_size = 4; |
There was a problem hiding this comment.
How about this ? cc @pnagaraj80
Suggested change
| //The bool value enables/disables the record count. | |
| //The default setting disables the record count. | |
| bool is_total_size = 4; | |
| // The bool value enables/disables the record count. | |
| // The default setting disables the record count. | |
| bool is_total_size_required = 4; |
There was a problem hiding this comment.
@chinmayb - This is not a required field. since we are using 'total_size' in PageInfo it better to keep 'is_total_size' here as well.
As comment says it is just to enable or disable the record count.
There was a problem hiding this comment.
for comment space will modify it
There was a problem hiding this comment.
the user is requesting the total count or not, hence I was asking that way. It doesn't indicate that its a required field or anything. More like
bool is_total_size_needed
chinmayb
reviewed
Nov 14, 2024
query/collection_operators.proto
Outdated
Comment on lines
226
to
227
| //Resultset record count. | ||
| int64 total_size = 4; |
There was a problem hiding this comment.
Suggested change
| //Resultset record count. | |
| int64 total_size = 4; | |
| // total_size indicates the total records present. | |
| int64 total_size = 4; |
chinmayb
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DDINGI-1306: Revised Data Paging/Totals
Enhancement to the existing pagination with resultset count with enable/disable count feature.