Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function to check nil Identifier #97

Merged
merged 2 commits into from
Aug 7, 2018
Merged

Function to check nil Identifier #97

merged 2 commits into from
Aug 7, 2018

Conversation

amaskalenka
Copy link
Contributor

No description provided.

@amaskalenka amaskalenka added the enhancement New feature or request label Aug 3, 2018
@amaskalenka amaskalenka changed the title Validation function for resource Identifier Function to check nil Identifier Aug 3, 2018
@amaskalenka
Copy link
Contributor Author

amaskalenka commented Aug 3, 2018 •
edited
Loading

It seems that we have test fluctuation, because locally make test passed.

--- FAIL: TestServe (0.00s)
    --- FAIL: TestServe/closing_grpc_server_closes_http_server (0.00s)
    	server_test.go:397: expected http server to be closed, but request was successfully sent
FAIL

@amaskalenka
Copy link
Contributor Author

amend

@Evgeniy-L Evgeniy-L merged commit 923006b into infobloxopen:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evgeniy-L Evgeniy-L Evgeniy-L approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amaskalenka @Evgeniy-L