install XRD like a CRD is installed #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandrorichardtoledo
approved these changes
Sep 24, 2024
EvertonCalgarotto
pushed a commit
that referenced
this pull request
Sep 27, 2024
EvertonCalgarotto
added a commit
that referenced
this pull request
Sep 30, 2024
* update how default engineversion is treated * update * comment * Updating dbclaim to valid db version * fix tests * rename properties to be like what enduser sees * update * fix tests * add comments * change namespace where secret is created * implement PR review suggestions * refacvtor * install XRD like a CRD is installed (#305) * put xrd in the templates folder and turn off pruning (#308) --------- Co-authored-by: Drew Wells <dwells@infoblox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move XRD to CRDs chart
Use crds folder so typical helm install functions as normal
Add a warning to not use
.Values.crds.installCRD upgrades will require flux
CreateReplaceor rendering out CRDs and replacing them with helm template