Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTEUDO-1652 convert deprecated annotations #341

Merged
merged 1 commit into from
Oct 25, 2024
Merged

PTEUDO-1652 convert deprecated annotations #341

merged 1 commit into from
Oct 25, 2024

Conversation

drewwells
Copy link
Contributor

As part of 1.10 a number of changes were made to mutating webhooks
for better resiliency of the k8s clusters. One drawback is a
number of apps would no longer get sidecars.

This introduces the same dangerous webhook as before but only to
convert the pods from old annotation syntax to new label syntax.
Removes redundant webhook tests from controller, it's too difficult
standing up a manager to bind the mutating webhooks to.

    As part of 1.10 a number of changes were made to mutating webhooks
    for better resiliency of the k8s clusters. One drawback is a
    number of apps would no longer get sidecars.

    This introduces the same dangerous webhook as before but only to
    convert the pods from old annotation syntax to new label syntax.
    Removes redundant webhook tests from controller, it's too difficult
    standing up a manager to bind the mutating webhooks to.
@drewwells drewwells merged commit 25d037a into main Oct 25, 2024
3 checks passed
@drewwells drewwells deleted the PTEUDO-1652 branch October 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants