Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTEUDO-1990: Prevent deletion requests DatabaseClaim CRs #368

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bfabricio
Copy link
Contributor

@bfabricio bfabricio commented Nov 29, 2024

Use a label to validate deletions of DatabaseClaim. A validating webhook will look for the presence or absence of this field to allow the deletion. If a user attempts to delete the CR, it will fail the request with a notice about the label requirement.

$ kubebuilder create webhook --version v1 --kind DbRoleClaim --group persistance --programmatic-validation
$ kubebuilder create webhook --version v1 --kind DatabaseClaim --group persistance --programmatic-validation

@bfabricio bfabricio changed the title PTEUDO-1990: Prevent deletion requests of dbroleclaim and databaseclaim CRs PTEUDO-1990: Prevent deletion requests of dbroleclaim and databaseclaim CRs (wip) Nov 29, 2024
@bfabricio bfabricio changed the title PTEUDO-1990: Prevent deletion requests of dbroleclaim and databaseclaim CRs (wip) PTEUDO-1990: Prevent deletion requests databaseclaim CRs (wip) Nov 29, 2024
@bfabricio bfabricio changed the title PTEUDO-1990: Prevent deletion requests databaseclaim CRs (wip) PTEUDO-1990: Prevent deletion requests DatabaseClaim CRs (wip) Nov 29, 2024
@bfabricio bfabricio changed the title PTEUDO-1990: Prevent deletion requests DatabaseClaim CRs (wip) PTEUDO-1990: Prevent deletion requests DatabaseClaim CRs Nov 29, 2024
@bfabricio bfabricio added the WIP label Nov 29, 2024
@bfabricio bfabricio marked this pull request as ready for review December 2, 2024 11:40
@bfabricio bfabricio removed the WIP label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants