Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SSL Verification in Request Options #190

Merged
merged 4 commits into from
Sep 12, 2018
Merged

Disable SSL Verification in Request Options #190

merged 4 commits into from
Sep 12, 2018

Conversation

mithun
Copy link
Contributor

@mithun mithun commented Mar 24, 2018

undo change from 3c5629e

From my testing with python-3.6, disabling SSL Verification on the session still attempts to verify certificates.

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files           7        7           
  Lines        1178     1178           
  Branches      197      197           
=======================================
  Hits         1011     1011           
  Misses        122      122           
  Partials       45       45
Impacted Files Coverage Δ
infoblox_client/connector.py 92.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b4788...ea57c57. Read the comment docs.

@mithun
Copy link
Contributor Author

mithun commented Apr 10, 2018

Hello,

It looks like @chinmayb has approved this PR. Please let me know if any more changes are proposed or if this PR is ready for merge.

@chinmayb
Copy link

@jkraj Can you please take a look once ?

@mithun
Copy link
Contributor Author

mithun commented May 8, 2018

Any updates on this PR?

@adsri
Copy link
Contributor

adsri commented Aug 21, 2018

Hi mithun,
Can you please provide me steps how you tested it.

As per my testing on python 3.6, it is working and not going for certificate verification.
Below is my steps:

  1. Install infoblox-client
  2. Created connector conn with credentials and ssl_verify=False
  3. Create objects using conn.create_object()
  4. It worked fine for me and didnot verified certificate.

@mithun
Copy link
Contributor Author

mithun commented Aug 25, 2018

@adsri It looks like the root cause is due to a bug in python-requests that wont be fixed until v3.

Until the issue is fixed in python-requests, the configuration will need to be applied at each request level.

@adsri adsri merged commit c1712dd into infobloxopen:master Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants