Fix a nasty bug when calling abstracted class from_dict with V4 & V6 subclass #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue:
When calling objects.NetworkContainer.from_dict(args)
the _custom_field_processing functions are not called
For example you get a list of dict for options instead of
list of Dhcpoption objects
This applies for all Objects that are subclass with V4 and V6
Root Cause:
from_dict NetworkContainer class methodis from InfobloxObject from_dict
classmethod
This parent class method from_dict is using the NetworkContainer class
attibutes (And there is none)
We definitly need to lookup the V4 or V6 subclass first to get
the class & attributes right
ExaneServerTeam
changed the title
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 90.94% 90.94%
=======================================
Files 7 7
Lines 4253 4254 +1
Branches 218 218
=======================================
+ Hits 3868 3869 +1
Misses 333 333
Partials 52 52
Continue to review full report at Codecov.
|
|
@AvRajath: Hello could you have a look at this PR ? |
|
@somashekhar @anagha-infoblox can someone verify? This LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When calling
objects.NetworkContainer.from_dict(args)the_custom_field_processingfunctions are not called.For example, you get a list of dict for options instead of list of Dhcpoption objects
Root Cause
from_dict NetworkContainer class methodis from InfobloxObject from_dict classmethod
This parent class method from_dict is using the NetworkContainer class attributes (And there is none)
We definitely need to look up the V4 or V6 subclass first to get the class & attributes right