Fix the password parsing issue #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queryescape user and password only if it is not already escaped.
ramya-bangera
force-pushed
the
ib-fix-pwd-escape
branch
from
8bf181b
to
d2aeaa1
Compare
kd7lxl
reviewed
Oct 14, 2024
Comment on lines
+15
to
+16
| input: "hello%20world", | ||
| expected: "hello%20world", |
There was a problem hiding this comment.
The flaw with this approach is a set of characters in a password like %20 would not be interpreted correctly.
| @@ -67,10 +67,20 @@ func printUsageAndExit() { | |||
|
|
|||
| func dbMakeConnectionString(driver, user, password, address, name, ssl string) string { | |||
| return fmt.Sprintf("%s://%s:%s@%s/%s?sslmode=%s", | |||
There was a problem hiding this comment.
Consider using URL.String() to assemble this string. It will apply the required escaping. url.UserPassword() will encapsulate the username and password.
|
Closing this in favour of ticket: https://infoblox.atlassian.net/browse/DEVOPS-28825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escaping an already escaped password is causing the migrate container to error out with the following error.
Added the fix to Queryescape user and password only if it is not already escaped.