fix: add option for image size

[yuanLeeMidori]

Hi, I add the feature to check different image sizes with keyboard shortcuts. This PR is for solving the issue #91.

While the user switch to the image tab,
z l change the search result to only large size;
z e change the search result to only medium size; (z m has been taken by filtering by past month)
z i change the search result to only icon size.

Take your time to review my code and please let me know if there is anything I can improve. Thank you!

[infokiller]

Will checking 'Large' works in other languages?

[infokiller]

Here and below you are calling dropDownWithSize.click() but dropDownWithSize may be undefined?

[infokiller]

I think it's better to use as input to the function something more descriptive than 'i', 'l', 'e'. Javascript doesn't have enums but you can simulate them: https://stackoverflow.com/q/287903/1014208

[infokiller]

Here and below you are calling dropDownWithSize.innerHTML but dropDownWithSize may be undefined?

[infokiller]

It seems possible to simplify the two switch statements. Not sure about the best way to do it, but maybe something like:

switch(size) {
  case LARGE:
    if (dropDownWithSize != null) {
      if (dropDownWithSize.innerHTML == 'Large') {
        return;
      }
      if (large == null) {
        dropDownWithSize.click();
        // large = ...
      }
    }
    if (large != null) {
      large.click();
    }
  // ...
}

Now basically some of the code in the case can be extracted out to a function, say something like:

const setImageSize = (dropDownWithSize, getButton) => {
  let button = getButton();
  if (dropDownWithSize != null && button == null) {
    dropDownWithSize.click();
    button = getButton();
  }
  if (button != null) {
    button.click();
  }
};

// ...


switch(size) {
  case LARGE:
    if (dropDownWithSize != null && dropDownWithSize.innerHTML == 'Large') {
      return;
    }
    setImageSize(dropDownWithSize, () => { 
      // return document...;
    });
    break;
  // ...
}

[infokiller]

@yuanLeeMidori no pressure, but just making sure you know I'm waiting for changes I requested in earlier comments

[yuanLeeMidori]

@infokiller Hi, thank you for the reminder. Sorry for keeping you wait. If you want, you can close this PR, and I'll send a new one with that meets these requirements once I get time to work on it. Thank you!

[infokiller]

Don't worry, there's no pressure. I just wanted to make sure you're not waiting for me :)

[yuanLeeMidori]

@infokiller Hi! Sorry for keeping you wait. I've made some changes based on your requests. Please let me know if there is anything I can improve. Thank you so much.

[infokiller]

@yuanLeeMidori thanks a lot for these changes and your contribution! from a quick look it looks good, but I'll want to test it a bit on my computer. I'm a bit busy in the next few days, so I'll probably get to it in a week or so.

[yuanLeeMidori]

@infokiller No worries! Take your time. Thank you for giving me the chance and help me to improve my code.

[infokiller]

Thanks a lot @yuanLeeMidori it looks great! I just merged it

[yuanLeeMidori]

@infokiller Thank you for the waiting and reviewing, I'm very grateful. Thank you for giving me the chance :)