Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use current translation keys #2427

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

hsiliev
Copy link
Collaborator

@hsiliev hsiliev commented Jan 16, 2025

Use the current translation keys for BAG screen

Solves PZ-4961

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has checked 2294 files.

Valid Invalid Ignored Fixed
2018 2 274 0
Click to see the invalid file list
  • src/test/kotlin/net/atos/zac/app/bag/BagFixtures.kt
  • src/test/kotlin/net/atos/zac/app/bag/converter/RESTAdreseerbaarObjectConverterTest.kt
Use this command to fix any missing license headers
```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jan 16, 2025

unit-test-results

 79 files  106 suites   1m 59s ⏱️
366 tests 365 ✅ 1 💤 0 ❌
458 runs  456 ✅ 2 💤 0 ❌

Results for commit 89c1e37.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

integration-test-results

 27 files   27 suites   35s ⏱️
106 tests 106 ✅ 0 💤 0 ❌
119 runs  119 ✅ 0 💤 0 ❌

Results for commit 89c1e37.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.95%. Comparing base (0766be7) to head (89c1e37).
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2427      +/-   ##
============================================
+ Coverage     52.51%   52.95%   +0.44%     
- Complexity     3163     3274     +111     
============================================
  Files           994      991       -3     
  Lines         22386    22519     +133     
  Branches       1741     1750       +9     
============================================
+ Hits          11757    11926     +169     
+ Misses         9858     9694     -164     
- Partials        771      899     +128     
Flag Coverage Δ
integrationtests 49.20% <100.00%> (+0.32%) ⬆️
unittests 33.27% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/main/app/src/assets/i18n/en.json Outdated Show resolved Hide resolved
Co-authored-by: Bas de Wit <52208549+bas-info-nl@users.noreply.github.com>
@hsiliev hsiliev marked this pull request as ready for review January 20, 2025 08:56
@hsiliev hsiliev requested a review from a team as a code owner January 20, 2025 08:56
Copy link
Contributor

@infonl-marcel infonl-marcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my remark about keys

src/main/app/src/assets/i18n/en.json Show resolved Hide resolved
@hsiliev hsiliev added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit a9f5849 Jan 20, 2025
23 checks passed
@hsiliev hsiliev deleted the fix/PZ-4961-adapt-translations-to-provided-bag-values branch January 20, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants