Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete CMMN Flowable case related data on zaak destroy notification #2677

Merged
merged 11 commits into from
Feb 12, 2025

Conversation

edgarvonk
Copy link
Member

Delete CMMN Flowable case related data on zaak destroy notification, including any Flowable tasks related to the case.. Not yet deleting any BPMN related data (future PR).

Solves PZ-3848

@edgarvonk edgarvonk requested review from hsiliev and a team as code owners February 12, 2025 13:22
Copy link
Contributor

unit-test-results

 83 files  +1  116 suites  +1   1m 34s ⏱️ +2s
410 tests +3  409 ✅ +3  1 💤 ±0  0 ❌ ±0 
509 runs  +3  507 ✅ +3  2 💤 ±0  0 ❌ ±0 

Results for commit 5987781. ± Comparison against base commit d37c999.

This pull request removes 3 and adds 6 tests. Note that renamed tests count towards both.
nl.info.zac.flowable.cmmn.CMMNServiceTest ‑ Then: it is successfully started
nl.info.zac.flowable.cmmn.CMMNServiceTest ‑ Then: it is successfully terminated
nl.info.zac.flowable.cmmn.UpdateZaakLifecycleListenerTest ‑ Then: the state for the zaak is updated in the ZGW API
net.atos.zac.flowable.ZaakVariabelenServiceTest ‑ Then: the zaak UUID is correctly returned
net.atos.zac.flowable.cmmn.CMMNServiceTest ‑ Then: it is successfully started
net.atos.zac.flowable.cmmn.CMMNServiceTest ‑ Then: it is successfully terminated
net.atos.zac.flowable.cmmn.CMMNServiceTest ‑ Then: the case is successfully deleted
net.atos.zac.flowable.cmmn.UpdateZaakLifecycleListenerTest ‑ Then: the state for the zaak is updated in the ZGW API
nl.info.zac.notification.NotificationReceiverTest ‑ Then: the CMMN case is successfully deleted and the zaak is removed from the search index

Copy link
Contributor

integration-test-results

 30 files  ±0   30 suites  ±0   38s ⏱️ -3s
113 tests ±0  113 ✅ ±0  0 💤 ±0  0 ❌ ±0 
126 runs  ±0  126 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5987781. ± Comparison against base commit d37c999.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
nl.info.zac.itest.NotificationsZaakDestroyTest ‑ Then: the response should be 'no content', and the zaak should be removed from the Solr index
nl.info.zac.itest.NotificationsZaakDestroyTest ‑ Then: the response should be 'no content', the Flowable CMMN zaak data should be deleted, the task should be deleted and the zaak should be removed from the Solr index

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.97%. Comparing base (d37c999) to head (5987781).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...a/net/atos/zac/flowable/ZaakVariabelenService.java 85.71% 1 Missing and 1 partial ⚠️
...n/nl/info/zac/notification/NotificationReceiver.kt 85.71% 2 Missing ⚠️
...n/kotlin/net/atos/zac/flowable/cmmn/CMMNService.kt 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2677      +/-   ##
============================================
+ Coverage     55.86%   55.97%   +0.11%     
- Complexity     3434     3448      +14     
============================================
  Files          1004     1004              
  Lines         22743    22777      +34     
  Branches       1778     1780       +2     
============================================
+ Hits          12705    12750      +45     
- Misses         9104     9210     +106     
+ Partials        934      817     -117     
Flag Coverage Δ
integrationtests 51.07% <85.71%> (+0.18%) ⬆️
unittests 36.00% <65.71%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarvonk edgarvonk enabled auto-merge February 12, 2025 14:23
@edgarvonk edgarvonk added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit a8ba968 Feb 12, 2025
21 checks passed
@edgarvonk edgarvonk deleted the feature/PZ-3848-delete-cmmn-case-on-zaak-destroy branch February 12, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants