Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description of index and leaf hash in absence proof #40

Closed
andrijamitrovic23 opened this issue Mar 2, 2023 · 4 comments
Closed

Description of index and leaf hash in absence proof #40

andrijamitrovic23 opened this issue Mar 2, 2023 · 4 comments
Assignees
@staheri14

Comments

@andrijamitrovic23
Copy link
Collaborator

@staheri14 Through this commit, descriptions about index and leaf hash in case of absence proof are changed in two places (first and second place) to be aligned with the documentation.

But there is a third description above the calculateAbsenceIndex function that needs to be changed too.
@staheri14 staheri14 mentioned this issue Mar 2, 2023
Merged
5 tasks
@staheri14
Copy link

Thanks @andrijamitrovic23 for bringing this to our attention! please see the fix in the following PR https://github.com/celestiaorg/nmt/pull/119/files

staheri14 added a commit to celestiaorg/nmt that referenced this issue Mar 2, 2023
@staheri14
chore: fixes the description of absence index in the calculateAbsence…
3bdcd9c 
…Index (#119)

## Overview

Addresses informalsystems/audit-celestia#40. 

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
@staheri14
Copy link

@andrijamitrovic23 Since the issue has been resolved, I think it makes sense for it to be closed, WDYT?

@andrijamitrovic23
Copy link
Collaborator Author

@staheri14 Yes, you can close it.

@rootulp
Copy link
Contributor

rootulp commented Sep 1, 2023

Closed by celestiaorg/nmt#119

@rootulp rootulp closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rootulp @staheri14 @andrijamitrovic23