Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize crate for better maintainability + add cli bin #81

Merged
merged 8 commits into from
Mar 2, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Mar 1, 2023

Closes: informalsystems/hermes#70

Description

This PR prepares basecoin-rs to be used as a library, making it easier to import reusable components and interfaces in particular as a pre-work toward IBC-rs and Hermes relayer-next tests.

The changes include:

  • Reorganized crate by breaking down modules for a more logical structure and being easier to navigate
  • Separated the bin and covered it within a CLI module for running the app
  • Improved encapsulation by adjusting public exposures (this might need further change upon trials in practice)

It ended up being more changes than expected! hopefully, it's what you had in mind @hu55a1n1 :).
Btw, Let me know if there's anything else you or @plafer like me to tweak.

@Farhad-Shabani Farhad-Shabani self-assigned this Mar 1, 2023
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review March 1, 2023 22:41
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@plafer plafer merged commit 2bbf690 into main Mar 2, 2023
@plafer plafer deleted the farhad/reorganize branch March 2, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce malicious behaviour in ICS3 TLA+ spec.
2 participants