Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize CLI logging and errors #190

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Standardize CLI logging and errors #190

wants to merge 23 commits into from

Conversation

seanchen1991
Copy link
Collaborator

Closes: #170

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991
Clean up start command
1ef5795
@seanchen1991
Clean up keys add command
ead66a2
@seanchen1991
Clean up create channel command
c6d5247
@seanchen1991
Clean up packet clear command
56fe7bf
@seanchen1991
Clean up client create command
311a79b
@seanchen1991
Clean up client update command
6ada78e
@seanchen1991
Clean up create connection command
96faff4
@seanchen1991
Clean up query client state command
db60058
@seanchen1991
Clean up query client status command
2ffa85d
@seanchen1991
Clean up query client consensus command
42f53d2
@seanchen1991
Clean up query connection end command
b73fe0c
@seanchen1991
Clean up query clients command
c2de3c0
@seanchen1991
Clean up query connections command
d26bce5
@seanchen1991
Clean up query channel client command
3d46d4d
@seanchen1991
Clean up query channel end command
f034aa4
@seanchen1991
Clean up query channel ends command
9059811
@seanchen1991
Clean up query channels command
eb25401
@seanchen1991
Clean up query pending packets command
020678c
@seanchen1991
Clean up query packet commitments command
b05800d
@seanchen1991
Clean up query packet pending acks command
c2df2f0
@seanchen1991
Fix channel_id:port_id formatting
d242c80
@seanchen1991
Tweak an error message
6d1f945
@seanchen1991
Better organize some dependencies
98ce52d
@seanchen1991 seanchen1991 marked this pull request as ready for review February 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize error reporting and logging across CLI
1 participant
@seanchen1991