Skip to content

Commit

Permalink
Avoid duplicate tag name for ConnectionEnd, ChannelEnd, AnyConsensusS…
Browse files Browse the repository at this point in the history
…tate and AnyClientState
  • Loading branch information
romac committed Feb 1, 2021
1 parent 9c98b89 commit 1ed6147
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions modules/src/ics02_client/client_def.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ impl From<AnyHeader> for Any {
}

#[derive(Clone, Debug, PartialEq, Eq, Serialize)]
#[serde(tag = "AnyClientState")]
#[serde(tag = "type")]
pub enum AnyClientState {
Tendermint(TendermintClientState),

Expand Down Expand Up @@ -273,7 +273,7 @@ impl ClientState for AnyClientState {
}

#[derive(Clone, Debug, PartialEq, Eq, Serialize)]
#[serde(tag = "AnyConsensusState")]
#[serde(tag = "type")]
pub enum AnyConsensusState {
Tendermint(TendermintConsensusState),

Expand Down
2 changes: 1 addition & 1 deletion modules/src/ics03_connection/connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use crate::ics24_host::error::ValidationError;
use crate::ics24_host::identifier::{ClientId, ConnectionId};

#[derive(Clone, Debug, PartialEq, Serialize)]
#[serde(tag = "ConnectionEnd")]
#[serde(tag = "type")]
pub struct ConnectionEnd {
state: State,
client_id: ClientId,
Expand Down
2 changes: 1 addition & 1 deletion modules/src/ics04_channel/channel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use crate::ics04_channel::{
use crate::ics24_host::identifier::{ChannelId, ConnectionId, PortId};

#[derive(Clone, Debug, PartialEq, Serialize)]
#[serde(tag = "ChannelEnd")] // Internal tagging, to make the type explicit in JSON outputs.
#[serde(tag = "type")] // Internal tagging, to make the type explicit in JSON outputs.
pub struct ChannelEnd {
// see https://serde.rs/enum-representations.html#internally-tagged
state: State,
Expand Down

0 comments on commit 1ed6147

Please sign in to comment.