Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyring store directory should be configurable #1541

Closed
5 tasks
soareschen opened this issue Nov 4, 2021 · 0 comments · Fixed by #3273
Closed
5 tasks

Keyring store directory should be configurable #1541

soareschen opened this issue Nov 4, 2021 · 0 comments · Fixed by #3273
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: new-feature Objective: cause to add a new feature or support O: tests Objective: Test more aspect of the relayer
Milestone

Comments

@soareschen
Copy link
Contributor

Crate

ibc-relayer

Summary

Currently the file-based key ring implementation always store the private keys for relayer wallet at ~/.hermes/keys. This is problematic for testing purposes as the temporary-generated private keys kept piling up at the developer's home directory.

#1521 currently use the in-memory key store to avoid polluting the home directory. However if we want to allow manual invocation of the relayer commands in the middle of the test, the wallet keys have to be exported to the filesystem for the relayer CLI to access it. For now I'd like to avoid exporting the keys to the home directory, and only do file export of keys inside the tests after this issue is resolved.

Proposal

Add a config field in config.toml to specify key store directory.

Acceptance Criteria

Running hermes command with customized config.toml should load wallet keys from directories other than ~/.hermes/keys.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@romac romac added O: new-feature Objective: cause to add a new feature or support A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Nov 5, 2021
@soareschen soareschen added the O: tests Objective: Test more aspect of the relayer label Nov 28, 2021
@soareschen soareschen removed their assignment Mar 17, 2022
@romac romac added this to the v1.6 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: new-feature Objective: cause to add a new feature or support O: tests Objective: Test more aspect of the relayer
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants