Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable keyring store directory #3273

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Configurable keyring store directory #3273

merged 5 commits into from
Apr 25, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Apr 25, 2023

Closes: #1541

Description

This PR adds a configuration allowing the user to specify which directory should be used for the keyring store.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added O: new-feature Objective: cause to add a new feature or support O: tests Objective: Test more aspect of the relayer I: configuration Internal: related to Hermes configuration labels Apr 25, 2023
@ljoss17 ljoss17 requested a review from romac April 25, 2023 11:17
romac
romac requested changes Apr 25, 2023
View reviewed changes
config.toml Outdated Show resolved Hide resolved
crates/relayer/src/config.rs Outdated Show resolved Hide resolved
crates/relayer/src/keyring.rs Outdated Show resolved Hide resolved
romac
romac reviewed Apr 25, 2023
View reviewed changes
config.toml Outdated Show resolved Hide resolved
@romac
Copy link
Member

romac commented Apr 25, 2023

Pushed a fix to ensure the default folder is under the $HOME directory and otherwise treat the given path as absolute: 0fc4087

@romac romac merged commit d5fa30d into master Apr 25, 2023
@romac romac deleted the luca_joss/configurable-keyring-store-directory branch April 25, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
I: configuration Internal: related to Hermes configuration O: new-feature Objective: cause to add a new feature or support O: tests Objective: Test more aspect of the relayer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyring store directory should be configurable
2 participants
@ljoss17 @romac