Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of Time::now() in ibc crate #1612

Closed
5 tasks
Tracked by #1158
soareschen opened this issue Nov 24, 2021 · 0 comments · Fixed by #1747
Closed
5 tasks
Tracked by #1158

Remove use of Time::now() in ibc crate #1612

soareschen opened this issue Nov 24, 2021 · 0 comments · Fixed by #1747
Labels
E: no-std External: support for no_std compatibility
Milestone
v0.12.0

Comments

@soareschen
Copy link
Contributor

Crate

ibc

Summary

Over the past month we have added to a number of places in the ibc module to get the current time. However the use of current time is not supported in no-std. The functions that need the current time needs to be refactored to accept the current time as an argument instead.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@soareschen soareschen added the E: no-std External: support for no_std compatibility label Nov 24, 2021
@soareschen soareschen mentioned this issue Nov 24, 2021
Closed
25 tasks
@adizere adizere added this to the v0.10.0 milestone Nov 29, 2021
@soareschen soareschen mentioned this issue Jan 6, 2022
Merged
6 tasks
mzabaluev added a commit that referenced this issue Jan 17, 2022
@mzabaluev
Fix up changelog link for #1612
ca06b38 
Unbreaks md-link-check workflow in the CI.
romac pushed a commit that referenced this issue Jan 17, 2022
@mzabaluev
Fix up changelog link for #1612 (#1778)
aacac3c 
Unbreaks md-link-check workflow in the CI.
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
@mzabaluev
Fix up changelog link for informalsystems#1612 (informalsystems#1778)
6ba901e 
Unbreaks md-link-check workflow in the CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E: no-std External: support for no_std compatibility
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Hide ibc::Timestamp::now() behind clock feature flag informalsystems/hermes
2 participants
@soareschen @adizere