Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable misbehavior detection by default #3001

Closed
5 tasks done
adizere opened this issue Jan 10, 2023 · 0 comments · Fixed by #3275
Closed
5 tasks done

Enable misbehavior detection by default #3001

adizere opened this issue Jan 10, 2023 · 0 comments · Fixed by #3275
Labels
A: good-first-issue Admin: good for newcomers I: configuration Internal: related to Hermes configuration O: security Objective: cause to enhance security and improve safety
Milestone

Comments

@adizere
Copy link
Member

adizere commented Jan 10, 2023

Summary

Following the work in #2001, we have managed to reduce the pressure on full nodes. This is a good moment for us to re-enable by default misbehavior detection.

https://github.com/informalsystems/hermes/blob/master/config.toml#L27

Problem Definition

Misbehavior detection is important. By keeping it disabled by default in Hermes, we encourage operators implicitly to keep it disabled. Following discussions with the IBC-go team, we have decided to enable this by default.

For more context, see this comment #2001 (comment)

Acceptance Criteria

  • Hermes out-of-the-box ships with misbehavior detection enabled by default
    • make misbehavior = true by default in the config.toml and default setting of the Hermes relayer library

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added A: good-first-issue Admin: good for newcomers O: security Objective: cause to enhance security and improve safety I: configuration Internal: related to Hermes configuration labels Jan 10, 2023
@adizere adizere added this to the v1.4 milestone Jan 10, 2023
@seanchen1991 seanchen1991 removed this from the v1.4 milestone Feb 3, 2023
@romac romac added this to the v1.6 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: good-first-issue Admin: good for newcomers I: configuration Internal: related to Hermes configuration O: security Objective: cause to enhance security and improve safety
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants