Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default misbehaviour detection #3275

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Apr 26, 2023

Closes: #3001

Description

This PR changes the default configuration for misbehaviour detection to be true.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 added O: security Objective: cause to enhance security and improve safety I: configuration Internal: related to Hermes configuration labels Apr 26, 2023
@ljoss17 ljoss17 requested a review from romac April 26, 2023 08:56
Signed-off-by: Romain Ruetschi <romain.ruetschi@gmail.com>
@romac romac merged commit bb80546 into master Apr 26, 2023
@romac romac deleted the luca_joss/enable-default-misbehavior-detection branch April 26, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: configuration Internal: related to Hermes configuration O: security Objective: cause to enhance security and improve safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable misbehavior detection by default
2 participants