Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destination chain to some metric labels #3297

Closed
5 tasks
Tracked by #3197
ljoss17 opened this issue May 2, 2023 · 0 comments · Fixed by #3302
Closed
5 tasks
Tracked by #3197

Add destination chain to some metric labels #3297

ljoss17 opened this issue May 2, 2023 · 0 comments · Fixed by #3302
Assignees
@ljoss17
Labels
I: telemetry Internal: related to Telemetry & metrics
Milestone
v1.5

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented May 2, 2023

Proposal

Currently Hermes metrics for confirmed packets do not have the destination chain in the label. Having it would allow to measure the performance per channel.

Acceptance Criteria

Metrics such as acknowledgment_packets_confirmed have the destination chain in the label.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added the I: telemetry Internal: related to Telemetry & metrics label May 2, 2023
@ljoss17 ljoss17 self-assigned this May 2, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes May 2, 2023
@ljoss17 ljoss17 mentioned this issue May 3, 2023
Merged
7 tasks
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🔖 Needs review in Hermes May 3, 2023
@seanchen1991 seanchen1991 moved this from 🔖 Needs review to 👀 In review in Hermes May 3, 2023
@seanchen1991 seanchen1991 mentioned this issue May 3, 2023
Open
3 tasks
@seanchen1991 seanchen1991 added this to the v1.5 milestone May 3, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Hermes May 16, 2023
yito88 added a commit to heliaxdev/hermes that referenced this issue May 30, 2024
@yito88
for Namada/informalsystems#3297 - split transfer tx
56362b7
yito88 added a commit to heliaxdev/hermes that referenced this issue Jun 5, 2024
@yito88
for Namada/informalsystems#3297 - split transfer tx
3e5ce8c
yito88 added a commit to heliaxdev/hermes that referenced this issue Jun 5, 2024
@yito88
for Namada/informalsystems#3297 - split transfer tx
1034b2d
yito88 added a commit to heliaxdev/hermes that referenced this issue Jun 14, 2024
@yito88
for Namada/informalsystems#3297 - split transfer tx
cc148b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljoss17 ljoss17

Labels
I: telemetry Internal: related to Telemetry & metrics
Projects
Hermes
Status: ✅ Done
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

Add destination chain to confirmed packet metrics informalsystems/hermes
2 participants
@seanchen1991 @ljoss17