Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove idle workers #3385

Closed
5 tasks
Tracked by #3217
ljoss17 opened this issue Jun 1, 2023 · 1 comment · Fixed by #3365
Closed
5 tasks
Tracked by #3217

Remove idle workers #3385

ljoss17 opened this issue Jun 1, 2023 · 1 comment · Fixed by #3365
Assignees
@ljoss17
Labels
I: refactoring O: performance Objective: cause to improve performance
Milestone
v1.6

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jun 1, 2023

Proposal

The packet worker should detect when it's been idle for too long and should abort its tasks.
In addition, some worker tasks are aborted after some conditions are met, but the workers are still kept in the WorkerMap. The idle workers should be removed from the WorkerMap.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 1, 2023
@ljoss17 ljoss17 mentioned this issue Jun 1, 2023
Merged
7 tasks
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🏗 In progress in Hermes Jun 5, 2023
@seanchen1991 seanchen1991 mentioned this issue Jun 5, 2023
Closed
3 tasks
@seanchen1991 seanchen1991 added O: performance Objective: cause to improve performance I: refactoring labels Jun 6, 2023
@seanchen1991 seanchen1991 added this to the v1.6 milestone Jun 6, 2023
@romac romac mentioned this issue Jun 26, 2023
Merged
7 tasks
@romac
Copy link
Member

romac commented Jun 26, 2023

Closed by #3365

@romac romac closed this as completed Jun 26, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljoss17 ljoss17

Labels
I: refactoring O: performance Objective: cause to improve performance
Projects
Hermes
Status: ✅ Done
Milestone
v1.6
3 participants
@romac @seanchen1991 @ljoss17