Add mechanism to remove idle workers #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_joss/clean-idle-workers
romac
reviewed
Jun 2, 2023
Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
…_joss/clean-idle-workers
…ons (eg. Tendermint 0.35 and 0.36) (#3404) * Use CompatMode::V0_34 when unsupported Tendermint version is detected * Use CompatMode::V0_37 when unsupported Tendermint version is detected * Fix warning when using fallback v0.37 CompatMode for Tendermint * Fix typo Signed-off-by: Romain Ruetschi <romain.ruetschi@gmail.com> --------- Signed-off-by: Romain Ruetschi <romain.ruetschi@gmail.com> Co-authored-by: Luca Joss <luca@informal.systems> Co-authored-by: Romain Ruetschi <romain@informal.systems>
…_joss/clean-idle-workers
romac
reviewed
Jun 13, 2023
.changelog/unreleased/improvements/ibc-relayer/10-cleanup-idle-workers.md
Outdated
Show resolved
Hide resolved
…-workers.md Signed-off-by: Romain Ruetschi <romain.ruetschi@gmail.com>
romac
added a commit
that referenced
this pull request
Jun 14, 2023
…bled and `clear_on_start = false` (#3365) * Only scan chains if 'clear_on_start=true' * Add supervisor tests when scanning is enabled and disabled * Add fees to ibc-transfer, required by Osmosis * Improve supervisor tests with and without chain scan * Add packet clearing test when scan is disabled * Fix clearing without scan test * Only scan when clear_on_start option is enabled, or client refresh or misbehavior workers are enabled, or the --full-scan argument is enabled * Update no scan tests * Disable channel and connection workers as well * Add mechanism to remove idle workers (#3370) * Add mechanism to remove idle workers * Add integration test for worker cleanup mechanism * Add idle channel worker integration test * Fix CI job * Improve worker cleanup test logs. Add changelog entry * Update crates/relayer/src/worker/handle.rs Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> * Update crates/relayer/src/worker/map.rs Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> * Update crates/relayer/src/worker/map.rs Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> * Apply github suggestions and fix error * Reduce idle worker cleanup frequency * Increase time between idle worker cleanup checks * Use CometBFT 0.37 compatibility mode for unsupported Tendermint versions (eg. Tendermint 0.35 and 0.36) (#3404) * Use CompatMode::V0_34 when unsupported Tendermint version is detected * Use CompatMode::V0_37 when unsupported Tendermint version is detected * Fix warning when using fallback v0.37 CompatMode for Tendermint * Fix typo * Small cleanup * Fix issue which spawned 2 supervisors in clean_workers tests * Remove assert which can cause 'test_clean_channel_workers' to fail wrongly * Update .changelog/unreleased/improvements/ibc-relayer/10-cleanup-idle-workers.md * Add documentation on no scan startup * Add changelog entry --------- Co-authored-by: Romain Ruetschi <romain@informal.systems> Co-authored-by: Sean Chen <seasn@informal.systems> Co-authored-by: Luca Joss <luca@informal.systems>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3385
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.