Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the topology used for Hermes tests #4038

Closed
5 tasks
Tracked by #3975
ljoss17 opened this issue Jun 12, 2024 · 0 comments · Fixed by #4039
Closed
5 tasks
Tracked by #3975

Allow specifying the topology used for Hermes tests #4038

ljoss17 opened this issue Jun 12, 2024 · 0 comments · Fixed by #4039
Assignees
Labels
O: testability Objective: cause to provide more testing tools and extensions
Milestone

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jun 12, 2024

Proposal

The current state of Hermes, e4be3e0, creates fully connected chains when running tests with more than 2 chains.

This impacts the run time of some tests, for example tests::forward::forward_hop_transfer::test_ibc_forward_hop_transfer can take up to 682.193 seconds to pass. Most of the time is spent in the connection and channel handshake as the bootstrap is fully connecting the 4 chains.
This is not necessary, if the chains are connected linearly, A -> B -> C -> D, the test would still work.

It should be possible to specify the topology used for nary chain tests in order to reduce the run time of some tests.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added the O: testability Objective: cause to provide more testing tools and extensions label Jun 12, 2024
@ljoss17 ljoss17 self-assigned this Jun 12, 2024
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Jun 12, 2024
@github-project-automation github-project-automation bot moved this from 🩹 Triage to ✅ Done in Hermes Jun 14, 2024
@ljoss17 ljoss17 added this to the v1.10 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: testability Objective: cause to provide more testing tools and extensions
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant