Specify topology for n-ary chain tests #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to use a specified topology
romac
reviewed
Jun 12, 2024
Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
|
Excellent work! Any insights on how much time this buys us on CI? |
romac
approved these changes
Jun 14, 2024
|
The test which received the most impact is the packet forward test:
The other chains went down a few minutes only as the other main test impacted is the The remaining very long job is for simapp v8, as it runs the highest number of tests, 86 tests but does not run forward tests. So it went down only from 1h31 to 1h25. |
|
Very nice, thanks for the report :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4038
Description
This PR refactors the bootstrapping of n-ary chain tests in order to use the specified topology. Only linear and fully connected are currently supported, and if the topology is not specified the linear one is used.
This also facilitates the implementation of new topologies if required.
PR author checklist:
unclog.Added tests: integration (for Hermes) or unit/mock tests (for modules).docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.